[pylint] Implement use-implicit-booleaness-not-len (PLC1802)
#14309
+825
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PLC1802 | 16 | 16 | 0 | 0 | 0 |
Lokejoke
changed the title
C1802)C1802)
Lokejoke
changed the title
C1802)[pylint] Implement use-implicit-booleaness-not-len (C1802)
Lokejoke
changed the title
[pylint] Implement use-implicit-booleaness-not-len (C1802)[pylint] Implement use-implicit-booleaness-not-len (C1802)
Lokejoke
changed the title
[pylint] Implement use-implicit-booleaness-not-len (C1802)[pylint] Implement use-implicit-booleaness-not-len (PLC1802)
dylwil3
requested changes
Nov 14, 2024
crates/ruff_linter/resources/test/fixtures/pylint/len_as_condition.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Could you test some more complicated examples involving rebindings/scope since you use those properties of the semantic model? Maybe something like:
def f(cond:bool):
x = [1,2,3]
if cond:
x = [4,5,6]
if len(x):
print(x)and
def g(cond:bool):
x = [1,2,3]
if cond:
x = [4,5,6]
if len(x):
print(x)
del xand
def h(cond:bool):
x = [1,2,3]
x = 123
if len(x):
print(x)and
def outer():
x = [1,2,3]
def inner(x:int):
return x+1
if len(x):
print(x)or any others you can think of to exercise the implementation.
There was a problem hiding this comment.
Good point, this implementation does support only one name assignment in current scope.
It would be fair to check all prior assignments to this.
dylwil3
added
rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements
use-implicit-booleaness-not-len/C1802Test Plan
Checked against pylint tests:
Notes
len-as-conditionmight be solution)References
PEP 8 on empty sequences and implicit booleaness